I wonder if we should land this behind an off-by-default flag? Or maybe that is more trouble than it is worth.

I'm shocked I haven't thought of this earlier... then I wouldn't have to keep updating this PR constantly

@LegNeato Buffers are easy, but for images, we can't just cfg within an asm!:

asm! {
    // error[E0658]: attributes on expressions are experimental
    // error: removing an expression is not supported in this position
    #[cfg(feature = "non-uniform")]
    "OpDecorate %image NonUniform"
    ...
}

We can't put it in a separate asm! either as we need to decorate the access instruction and all it's parameters (as a precaution). The correct way would be to cfg the entire asm! and duplicate all the image access asm!, about 200 loc.

Would you mind if I just add a linking stage instead to remove all OpDecoration if the target feature ShaderNonUniform is not present? (cc @eddyb)

I'm personally fine with either a linking stage or copying 200 lines (or a macro so no need to copy?)

I've taken the linking stage filter route and added the NonUniform decoration it everywhere, hopefully didn't miss anything. Tested it on my project too.

I've added some tests in branch byte_adressable_buffer_from_runtime_array, which work on spv1.3 but fail on vulkan1.2. That behavior doesn't change on master, so unrelated to this PR. Weirdly enough, that's exactly how I'm using them in my project, yet it compiles with vulkan1.2 just fine.